refactor(@ngtools/webpack): use webpack API to delete assets in compilation#22297
Merged
filipesilva merged 1 commit intoangular:masterfrom Dec 6, 2021
alan-agius4:asset-webpack-api
Merged
refactor(@ngtools/webpack): use webpack API to delete assets in compilation#22297filipesilva merged 1 commit intoangular:masterfrom alan-agius4:asset-webpack-api
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:asset-webpack-api
Conversation
alan-agius4
added
the
target: minor
alan-agius4
commented
Dec 3, 2021
| delete childCompilation.assets[outputFilePath + '.map']; | ||
| for (const { files } of childCompilation.chunks) { | ||
| for (const file of files) { | ||
| childCompilation.deleteAsset(file); |
Collaborator
Author
There was a problem hiding this comment.
Yes, we want to delete all chunk assets
dgp1130
approved these changes
Dec 3, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.